chore(python): fix prerelease session [autoapprove]#1504
Merged
Conversation
This was referenced Jul 24, 2022
This was referenced Jul 24, 2022
dandhlee
approved these changes
Jul 25, 2022
parthea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the prerelease session. I tested the changes by running
docker build -f docker/owlbot/python/Dockerfile -t prerelease .in this repo, then runningdocker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo prereleasein downstream repositories.I removed the samples testing from the prerelease session as the testing for samples is more complicated as there is a separate docker image and a lot of custom logic. A separate presubmit check should be added for testing prerelease versions of samples.