Skip to content

ci: update template so GAPIC_AUTO repos do not require special approvers for Java code #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suztomo merged 5 commits into from
Jul 18, 2022
Merged

ci: update template so GAPIC_AUTO repos do not require special approvers for Java code #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef4544b
ci: gapic auto repositories not to have special codeowners
suztomo Jul 15, 2022
4d9473f
ci: adding comment for codeowners for handwritten libs
suztomo Jul 16, 2022
67de18e
Merge branch 'master' into gapic_auto_approver
suztomo Jul 18, 2022
45ec21a
ci: reviewer for samples java-samples-reviewers
suztomo Jul 18, 2022
5644efb
Merge remote-tracking branch 'origin/master' into gapic_auto_approver
suztomo Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions synthtool/gcp/templates/java_library/.github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
{% if 'codeowner_team' in metadata['repo'] %}
# The {{ metadata['repo']['codeowner_team'] }} is the default owner for changes in this repo
* @googleapis/yoshi-java {{ metadata['repo']['codeowner_team'] }}
{% if 'library_type' in metadata['repo'] and metadata['repo']['library_type'] != 'GAPIC_AUTO' %}
Copy link
Copy Markdown

@iennae iennae Jul 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest adding a comment of something like

# for handwritten libraries keep {{ metadata['repo']['codeowner_team'] }} as owner

Copy link
Copy Markdown
Member Author

@suztomo suztomo Jul 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the next line.

# for handwritten libraries, keep codeowner_team in .repo-metadata.json as owner
**/*.java {{ metadata['repo']['codeowner_team'] }}
{% endif %}
{% else %}
* @googleapis/yoshi-java
{% endif %}
Expand Down
3 changes: 3 additions & 0 deletions synthtool/gcp/templates/java_library/.github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ permissionRules:
permission: admin
- team: yoshi-java
permission: push
- team: java-samples-reviewers
permission: push
Comment on lines +61 to +62
Copy link
Copy Markdown
Member Author

@suztomo suztomo Jul 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @kolea2 @averikitsch This should give "Write" role to the team.

Copy link
Copy Markdown
Member Author

@suztomo suztomo Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately OwlBot (postpostprocessor) didn't modify sync-repo-settings.yaml in https://github.com/googleapis/java-containeranalysis/pull/912/files