build: make ci testing conditional on engines field in package.json, move configs to Node 12#1418
Merged
build: make ci testing conditional on engines field in package.json, move configs to Node 12#1418
Conversation
sofisl
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
sofisl
changed the title
bcoe
suggested changes
Apr 13, 2022
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
Looking slick to me, left a recommendation for a test and a tiny refactor.
| data["repository"] = f'{repo["owner"]}/{repo["name"]}' | ||
| data["repository_name"] = repo["name"] | ||
| data["lib_install_cmd"] = f'npm install {data["name"]}' | ||
| data["engine"] = data["engines"]["node"].replace(">=", "").replace(".0", "") |
There was a problem hiding this comment.
I feel like some of our repos might be >=10.0.0, what you might do is a regex that looks for the first instance of a digit followed by a . and captures it.
I think it would be worth adding a test for this helper, since it's a little finicky.
bcoe
reviewed
Apr 14, 2022
bcoe
reviewed
Apr 14, 2022
bcoe
reviewed
Apr 14, 2022
bcoe
approved these changes
Apr 14, 2022
loferris
pushed a commit
that referenced
this pull request
Apr 19, 2022
…move configs to Node 12 (#1418) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 Co-authored-by: Benjamin E. Coe <[email protected]>
parthea
added a commit
that referenced
this pull request
Apr 20, 2022
* adding notebook template function * changing template path * changing template path * chore: add googleapis/yoshi-python to CODEOWNERS (#1380) * chore(python): add E231 to .flake8 ignore list (#1379) * chore: Enable Size-Label bot in all googleapis Python notebook testing (#1384) * chore: Enable Size-Label bot in all googleapis Python notebook testing repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python notebook testing repositories * Remove product Remove product since it is by default true * chore(python): Enable size-label bot (#1383) * chore: Enable Size-Label bot in all googleapis Python repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python repositories * Remove product Remove product since it is by default true Co-authored-by: Anthonios Partheniou <[email protected]> * chore(python): update .pre-commit-config.yaml to use black==22.3.0 (#1378) Co-authored-by: Tim Swast <[email protected]> * chore(python): Enable size-label bot (#1385) * chore: remove dependency on google-api-core (#1372) * chore(deps): update dependency google-api-core to v2.7.1 * chore: remove dependency on google-api-core Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency numpy to v1.22.3 (#1387) * chore(deps): disable dependency dashboard (#1223) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency pandas to v1.4.1 (#1258) Co-authored-by: Anthonios Partheniou <[email protected]> * build(deps): bump ipython (#1336) Bumps [ipython](https://github.com/ipython/ipython) from 7.0 to 7.16.3. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.0.0...7.16.3) --- updated-dependencies: - dependency-name: ipython dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: remove use of googleapis-discovery (#1280) * chore: remove use of googleapis-discovery * remove constant and method for googleapis-discovery Co-authored-by: Anthonios Partheniou <[email protected]> * chore: add classifiers for python 3.7, 3.8 and 3.9 (#1247) added Support for python 3.7, 3.8, 3.9 Co-authored-by: Anthonios Partheniou <[email protected]> * chore(python): refactor unit / system test dependency install (#1294) * chore(python): refactor unit / system test dependency install Closes #1185. * chore: use editable installs for local deps * chore: don't install deps using '-e' * chore: deprecate 'unit_test_external_dependencies' * fix: install standard + main unit test deps together FBO pip resolver. Co-authored-by: Anthonios Partheniou <[email protected]> * chore(python_notebooks): update dependency black to v22 (#1396) * chore(deps): update dependency ipython to v8 (#1397) Co-authored-by: Anthonios Partheniou <[email protected]> * chore: Enable Size-Label bot in all googleapis NodeJs repositories (#1382) * chore: Enable Size-Label bot in all googleapis NodeJs repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis NodeJs repositories * Remove product Remove product since it is by default true * chore(deps): update dependency setuptools to v61 (#1398) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency org.sonatype.plugins:nexus-staging-maven-plugin to v1.6.12 (#1388) Co-authored-by: Neenu Shaji <[email protected]> * ci: update testing pipeline for notebooks (#1345) * update testing pipeline * kokoro fix * fixing linting errors * Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py Co-authored-by: Anthonios Partheniou <[email protected]> * Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py Co-authored-by: Anthonios Partheniou <[email protected]> * resolving license year * removing redundant print statements * adding developer todos * reverting protos * resetting protos to main Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update actions/setup-python action to v3 (#1395) Co-authored-by: Anthonios Partheniou <[email protected]> * chore: upgrade black in noxfile.py to 22.3.0 (#1377) * chore: upgrade black to 22.3.0 * update lint also * run blacken session * ci: use click>8.0 for blacken/lint sessions * chore: fix typo Co-authored-by: nicain <[email protected]> * rebase error Co-authored-by: nicain <[email protected]> * chore(deps): update dependency pandas to v1.4.2 (#1400) * chore(deps): update dependency setuptools to v61.3.1 (#1399) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency nbqa to v1.3.1 (#1391) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency protobuf to v3.19.4 (#1389) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency protobuf to v3.20.0 (#1403) * chore(deps): update dependency setuptools to v62 (#1406) * chore(python): Use python 3.10.4 base image for post processor (#1405) * chore(deps): update actions/setup-node action to v3 (#1393) Co-authored-by: Jeffrey Rennie <[email protected]> * chore(python): add license header to auto-label.yaml (#1404) * chore: improve logic to configure release-please for previous major versions (#1408) * fix: allow version.py files without the library version * chore: remove obsolete file * chore: run black Co-authored-by: Anthonios Partheniou <[email protected]> * chore: Enable Size-Label bot in all googleapis Java repositories (#1381) * chore: Enable Size-Label bot in all googleapis Java repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories * Remove product Remove product since it is by default true * add license header Co-authored-by: Neenu Shaji <[email protected]> * chore(deps): update actions/checkout action to v3 (#1392) Co-authored-by: Jeffrey Rennie <[email protected]> * chore: run tests with Python 3.10 (#1407) Co-authored-by: Anthonios Partheniou <[email protected]> * chore(deps): update dependency python to v3.10.4 (#1386) Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> * fix: clarify the gax-nodejs usage in README (#1352) Co-authored-by: Benjamin E. Coe <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> * Revert "fix: clarify the gax-nodejs usage in README (#1352)" (#1409) This reverts commit e1557e4. * chore(deps): update dependency pyupgrade to v2.32.0 (#1412) * chore(deps): update dependency nbconvert to v6.5.0 (#1414) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 (#1418) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 Co-authored-by: Benjamin E. Coe <[email protected]> * build: sdd srs yaml file (#1419) * build: add sync-repo-settings and change branch protection * update names for template * adding type annotation Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: losalex <[email protected]> Co-authored-by: Tim Swast <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Dan Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brent Shaffer <[email protected]> Co-authored-by: Anurag Kumar <[email protected]> Co-authored-by: Tres Seaver <[email protected]> Co-authored-by: Neenu Shaji <[email protected]> Co-authored-by: nicain <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Summer Ji <[email protected]> Co-authored-by: Benjamin E. Coe <[email protected]> Co-authored-by: sofisl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting Node 10 configs here, but we will also have to delete them in each repo.
cc @bcoe