chore(python): configure release-please on previous major versions#1369
Merged
busunkim96 merged 12 commits intomasterfrom Mar 23, 2022
Merged
chore(python): configure release-please on previous major versions#1369busunkim96 merged 12 commits intomasterfrom
busunkim96 merged 12 commits intomasterfrom
Conversation
busunkim96
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
Contributor
|
@busunkim96 , I applied the update on a repo that doesn't have a previous major version. There are no branches listed under |
parthea
approved these changes
Mar 22, 2022
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Added one observation, otherwise LGTM
chingor13
requested changes
Mar 22, 2022
Comment on lines
+155
to
+163
| # NOTE: this section is generated by synthtool.languages.python | ||
| # See https://github.com/googleapis/synthtool/blob/master/synthtool/languages/python.py | ||
| branches: | ||
| - branch: v1 | ||
| handleGHRelease: true | ||
| releaseType: python | ||
| - branch: v0 | ||
| handleGHRelease: true | ||
| releaseType: python""" |
Contributor
There was a problem hiding this comment.
I think this indentation is wrong. branches should not have leading spaces
…ool into py-release-from-branch
busunkim96
commented
Mar 22, 2022
chingor13
requested changes
Mar 22, 2022
Comment on lines
+198
to
+200
| Path(".github/release-please.yml").write_text( | ||
| release_please_yml + branch_release_config | ||
| ) |
Contributor
There was a problem hiding this comment.
Is this idempotent? It looks like it will just keep appending to the file.
Also, it might be cleaner to build it as a dict and export to yaml.
chingor13
approved these changes
Mar 23, 2022
busunkim96
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the current Python library release version from the
setup.pyorversion.pyand add release-please branch configs for all previous major versions.Repos where I tested this:
owlbot.py, version inversion.py)owlbot.py)owlbot.py)