Skip to content

chore(python): fix undefined name 'glob' in samples noxfile#1324

Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix-missing-import-noxfile
Jan 11, 2022
Merged

chore(python): fix undefined name 'glob' in samples noxfile#1324
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix-missing-import-noxfile

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jan 11, 2022

PR #1321 added glob.glob but the import statement was missing.

@parthea parthea requested review from a team, busunkim96 and leahecole January 11, 2022 11:54
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jan 11, 2022
Copy link
Copy Markdown

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we caught this reasonably early

@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 52aef91 into master Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the fix-missing-import-noxfile branch January 11, 2022 12:04
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@leahecole
Copy link
Copy Markdown
Contributor

Oh NO!!! I am so sorry. I caught it in the template in p-d-s but not here. Thank you SO MUCH @parthea !!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants