Conversation
google-cla
Bot
added
the
cla: yes
Fixes #1287 google-java-format 1.11.0 is the version used by fmt-maven-plugin 2.12 (latest as of November 2021).
suztomo
force-pushed
the
suztomo-patch-1
branch
from
627fdba to
8aab0b8
Compare
Member
Author
|
Member
Author
|
Why did it fail? |
chanseokoh
reviewed
Nov 23, 2021
chanseokoh
changed the title
Member
Author
|
@chingor13 Would you mind taking over this? I don't have visibility into the failing build log and not familiar with the release process of Owlbot. |
Contributor
|
I don't have access to the build log either, but try updating this test data. |
4 tasks
Member
Author
|
@chanseokoh Great. Now it passed owlbot-java-presubmit check. Thank you. |
Member
Author
|
All checks have passed. |
lesv
approved these changes
Nov 29, 2021
Contributor
|
This PR is causing owlbot post processor to thrash and fail owlbot check in java client libraries. |
Neenu1995
added a commit
that referenced
this pull request
Nov 29, 2021
This reverts commit fdf20ea.
lesv
pushed a commit
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1287
googleapis/java-shared-config#361 sets the google-java-format version 1.13.0. Timur already committed the Java version upgrade for the linter. 42a3786
As per @chingor13 , the formatter version was previously pinned to the old formatter because of Java 7 support.