chore(python): run blacken session for all directories with a noxfile#1276
Merged
chore(python): run blacken session for all directories with a noxfile#1276
Conversation
parthea
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
google-cla
Bot
added
the
cla: yes
This was referenced Nov 7, 2021
Contributor
Author
|
@busunkim96, Please could you review/approve? |
busunkim96
reviewed
Nov 9, 2021
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
I think this will fail in google-auth because it has a noxfile.py with no blacken. Is there a way to opt out for that repo?
Contributor
Author
|
@busunkim96 Good find! I think it won't be an issue as the change is in |
busunkim96
approved these changes
Nov 10, 2021
chingor13
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many python repositories have a separate
noxfile.pyfile in thesamplesdirectory. This PR modifiesowlbot_main()for python to run theblackennox session on all directories that contain anoxfile.pyrather than only the root of the repository.I tested the changes using the following commands after cloning synthtool
Once the docker image was built, I ran the following commands in the root of python-apigee-connect which has no samples and python-secret-manager which has samples. I've confirmed that the blacken session runs on all directories that have
noxfile.py.