chore(python): modify templated noxfile to support non-cloud APIs#1263
Merged
chore(python): modify templated noxfile to support non-cloud APIs#1263
Conversation
google-cla
Bot
added
the
cla: yes
This was referenced Oct 21, 2021
busunkim96
approved these changes
Oct 21, 2021
This was referenced Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
owlbot.pyfile for non-cloud APIs need to have replacements inowlbot.pyin order to use the templated noxfile. See the example frompython-analytics-adminhere which has:This PR eliminates the need for this replacement in owlbot.py. I tested this change in googleapis/python-orchestration-airflow#41, and googleapis/python-analytics-admin#157 and the Kokoro build passed in both.