Skip to content

chore(python): fix formatting issue in noxfile.py.j2#1241

Merged
parthea merged 1 commit intomasterfrom
fix-formatting-issue-in-noxfile
Oct 12, 2021
Merged

chore(python): fix formatting issue in noxfile.py.j2#1241
parthea merged 1 commit intomasterfrom
fix-formatting-issue-in-noxfile

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Oct 8, 2021

PR #1237 fixed a formatting issue in noxfile.py.j2 however after running the latest post processor image, there is still a syntax issue.

Here are the steps that I ran to validate this fix.

Checkout the branch for this PR and run the following:

docker build -t testlogging -f docker/owlbot/python/Dockerfile .

In the python-logging repo, run

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testlogging

@parthea parthea requested a review from a team October 8, 2021 23:58
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@parthea parthea merged commit 0e85ed6 into master Oct 12, 2021
@parthea parthea deleted the fix-formatting-issue-in-noxfile branch October 12, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants