build: use trampoline_v2 for python samples and allow custom dockerfile#1232
Merged
busunkim96 merged 4 commits intomasterfrom Oct 5, 2021
Merged
build: use trampoline_v2 for python samples and allow custom dockerfile#1232busunkim96 merged 4 commits intomasterfrom
busunkim96 merged 4 commits intomasterfrom
Conversation
product-auto-label
Bot
added
the
samples
google-cla
Bot
added
the
cla: yes
busunkim96
changed the title
This was referenced Oct 1, 2021
busunkim96
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
tseaver
approved these changes
Oct 1, 2021
parthea
approved these changes
Oct 1, 2021
chingor13
approved these changes
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use trampoline_v2 (Docker CI Helper) for all python samples.
Optionally allow samples to run with a Dockerfile specified in the library repository at
.kokoro/docker/samples. On a successful test run, this Dockerfile is uploaded togcr.io/cloud-devrel-kokoro-resources/{repo-name}-samples-docker. The option is enabled by passingcustom_samples_dockerfile=Truetocommon.py_libraryinowlbot.py.See googleapis/python-asset#308 for an example of moving samples to to trampoline_v2.
See googleapis/python-recaptcha-enterprise#128 for an example of moving to trampoline_v2 + using a custom Dockerfile.