build: add jdk 17 to java units and dependency builds#1216
Merged
BenWhitehead merged 2 commits intogoogleapis:masterfrom Sep 27, 2021
BenWhitehead:jdk-17
Merged
build: add jdk 17 to java units and dependency builds#1216BenWhitehead merged 2 commits intogoogleapis:masterfrom BenWhitehead:jdk-17
BenWhitehead merged 2 commits intogoogleapis:masterfrom
BenWhitehead:jdk-17
Conversation
* update dependencies.sh to not pass MaxPermSize when jdk 17 is used. MaxPermSize is an unrecognized flag in jdk 17.
google-cla
Bot
added
the
cla: yes
crwilcox
approved these changes
Sep 17, 2021
chingor13
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prototpe of these changes has been tested in googleapis/java-storage#1016