feat: Remove use of deprecated gradle command in java README#1196
Merged
JesseLovelace merged 1 commit intomasterfrom Aug 27, 2021
Merged
feat: Remove use of deprecated gradle command in java README#1196JesseLovelace merged 1 commit intomasterfrom
JesseLovelace merged 1 commit intomasterfrom
Conversation
Per internal bug 197475869, the "compile" command in gradle has been deprecated in favor of "implementation" for many years, and is actually removed in the latest versions of gradle
google-cla
Bot
added
the
cla: yes
suztomo
approved these changes
Aug 26, 2021
| @@ -50,14 +50,14 @@ If you are using Gradle 5.x or later, add this to your dependencies | |||
| ```Groovy | |||
| implementation platform('com.google.cloud:libraries-bom:{{metadata['latest_bom_version']}}') | |||
Member
There was a problem hiding this comment.
Interesting. This line already uses "implementation" configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per internal bug 197475869, the "compile" command in gradle has been deprecated in favor of "implementation" for many years, and is actually removed in the latest versions of gradle