chore: drop mention of Python 2.7 from templates#1173
Merged
tseaver merged 8 commits intogoogleapis:masterfrom Aug 13, 2021
tseaver:1118-remove-python2.7-from-templates
Merged
chore: drop mention of Python 2.7 from templates#1173tseaver merged 8 commits intogoogleapis:masterfrom tseaver:1118-remove-python2.7-from-templates
tseaver merged 8 commits intogoogleapis:masterfrom
tseaver:1118-remove-python2.7-from-templates
Conversation
tseaver
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
google-cla
Bot
added
the
cla: yes
This was referenced Aug 1, 2021
parthea
changed the title
parthea
approved these changes
Aug 2, 2021
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Added minor observations, otherwise LGTM.
Co-authored-by: Anthonios Partheniou <[email protected]>
Reorder standard deps, external deps for clarity.
Samples are tested via separate noxfiles in all repos which have them.
Contributor
Author
|
Hmm, @parthea I'm surprised your review is not sufficient to allow a merge. Because I touched
I would've expected that you were a member of @googleapis/github-automation. |
Contributor
|
@bcoe Please can you take a look for @googleapis/github-automation? |
bcoe
approved these changes
Aug 12, 2021
tseaver
pushed a commit
to googleapis/python-compute
that referenced
this pull request
Aug 16, 2021
m-strzelczyk
pushed a commit
to GoogleCloudPlatform/python-docs-samples
that referenced
this pull request
Nov 9, 2022
dandhlee
pushed a commit
to GoogleCloudPlatform/python-docs-samples
that referenced
this pull request
Nov 16, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1118.