Skip to content

chore: fix kokoro config for samples#1167

Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix-kokoro-sample-config
Jul 23, 2021
Merged

chore: fix kokoro config for samples#1167
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix-kokoro-sample-config

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jul 23, 2021 •
edited
Loading

Fixes #1166

I tested these changes by running the following commands after cloning synthtool

git checkout fix-kokoro-sample-config
docker build -t testkokoro -f docker/owlbot/python/Dockerfile .

Once the docker image was built, I ran the following command in the root of python-aiplatform

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testkokoro

which produced the following changes

partheniou@partheniou-vm-1:~/git/python-aiplatform$ git diff .kokoro
diff --git a/.kokoro/samples/python3.6/periodic-head.cfg b/.kokoro/samples/python3.6/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.6/periodic-head.cfg
+++ b/.kokoro/samples/python3.6/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.7/periodic-head.cfg b/.kokoro/samples/python3.7/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.7/periodic-head.cfg
+++ b/.kokoro/samples/python3.7/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.8/periodic-head.cfg b/.kokoro/samples/python3.8/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.8/periodic-head.cfg
+++ b/.kokoro/samples/python3.8/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.9/periodic-head.cfg b/.kokoro/samples/python3.9/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.9/periodic-head.cfg
+++ b/.kokoro/samples/python3.9/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }

@parthea parthea requested a review from a team July 23, 2021 14:28
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2021
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 23, 2021
@parthea parthea mentioned this pull request Jul 23, 2021
Merged
2 tasks
@parthea parthea requested review from busunkim96 and leahecole July 23, 2021 14:36
@parthea parthea changed the title chore: fix.kokoro config for samples chore: fix kokoro config for samples Jul 23, 2021
@parthea parthea force-pushed the fix-kokoro-sample-config branch from 80f974f to c996eeb Compare July 23, 2021 14:37
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit dd05f9d into master Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the fix-kokoro-sample-config branch July 23, 2021 14:56
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole Awaiting requested review from leahecole

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(python): kokoro sample configs have hardcoded repo python-pubsub

2 participants

@parthea @busunkim96