Skip to content

chore(java): add a method to copy a java method and rename it#1162

Merged
gcf-merge-on-green[bot] merged 27 commits intomasterfrom
duplicate-method-java
Jul 23, 2021
Merged

chore(java): add a method to copy a java method and rename it#1162
gcf-merge-on-green[bot] merged 27 commits intomasterfrom
duplicate-method-java

Conversation

@Neenu1995
Copy link
Copy Markdown
Contributor

@Neenu1995 Neenu1995 commented Jul 19, 2021

chore: add method to deprecate java methods

@Neenu1995 Neenu1995 requested a review from a team July 19, 2021 19:54
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
Comment thread synthtool/languages/java.py
Comment thread synthtool/languages/java.py Outdated
Comment thread tests/testdata/SampleCopyMethodGolden.java
Comment thread tests/testdata/SampleDeprecateMethodGolden.java Outdated
Comment thread tests/testdata/SampleDeprecateMethodGolden.java Outdated
Comment thread tests/test_language_java.py Outdated
Comment thread tests/testdata/SampleDeprecateMethodGolden.java Outdated
Comment thread tests/testdata/SampleDeprecateMethodGolden.java Outdated
Comment on lines +27 to +33
/*
* @deprecated This method will be removed in the next major version.
* Use {@link #sample()} instead
*/
@Beta
@Generated()
@Deprecated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all incorrect, and we can fix this.

@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit f7d068c into master Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the duplicate-method-java branch July 23, 2021 01:14
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants