Skip to content

build(node): do not throw on deprecation#1140

Merged
bcoe merged 2 commits intomasterfrom
no-throw-dep
Jun 25, 2021
Merged

build(node): do not throw on deprecation#1140
bcoe merged 2 commits intomasterfrom
no-throw-dep

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Jun 25, 2021

We created a ton of flaky bot issues, due to to ignoring deprecation warnings only in our GitHub action unit tests:

Refs googleapis/nodejs-service-usage#22

@bcoe bcoe requested a review from a team June 25, 2021 14:17
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2021
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 25, 2021
@bcoe
Copy link
Copy Markdown
Author

bcoe commented Jun 25, 2021

going to hold off on merging this until I'm a tiny bit more caught up on PRs.

@bcoe bcoe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 25, 2021
@bcoe bcoe merged commit 6d26b13 into master Jun 25, 2021
@bcoe bcoe deleted the no-throw-dep branch June 25, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants