build: enable npm for php/python builds#1133
Merged
Conversation
google-cla
Bot
added
the
cla: yes
SurferJeffAtGoogle
approved these changes
Jun 22, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
) Fixes #1134 🦕 Removes the commit body and relative PR# from the commit message. For example, for this commit: 9763f20 `post-processor-changes.txt` would contain ``` build: enable npm for php/python builds Source-Link: 9763f20 ``` instead of ``` build: enable npm for php/python builds (#1133) * build: enable npm for php/python builds * update comment Source-Link: 9763f20 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the nicer code formatting tools I've found for PHP is, interestingly enough, written in node: https://github.com/prettier/plugin-php
I was hoping to use it as part of our synth scripts to help smooth over some recent changes from the microgenerator. Ultimately I think I'd like to work this into the microgenerator, but am hoping this would be an acceptable alternative until then.
These additions are copied over from node's build file and based upon reviewing the changes here. If there is a more appropriate way to achieve this here or we'd prefer to have a separate build file for PHP, please let me know, but it seemed relatively low impact to include this for python as well.