fix: make generate_index_ts() deterministic#1104
Merged
SurferJeffAtGoogle merged 1 commit intogoogleapis:masterfrom May 27, 2021
Merged
fix: make generate_index_ts() deterministic#1104SurferJeffAtGoogle merged 1 commit intogoogleapis:masterfrom
generate_index_ts() deterministic#1104SurferJeffAtGoogle merged 1 commit intogoogleapis:masterfrom
Conversation
google-cla
Bot
added
the
cla: yes
tmatsuo
approved these changes
May 27, 2021
Contributor
|
Ok to merge. Can we eventually have an integration test which make sure it's deterministic if it makes sense. |
bcoe
approved these changes
May 27, 2021
chingor13
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1103