build: add auto-approve to Node libraries#1100
Conversation
google-cla
Bot
added
the
cla: yes
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
I'm excited to turn on auto-merging releases, I think it might be worth discussing our OwlBot lock file merging with @chingor13 and @SurferJeffAtGoogle.
| @@ -11,3 +11,6 @@ | |||
| {%- else %} | |||
| * @googleapis/yoshi-nodejs | |||
There was a problem hiding this comment.
Thinking out load, are we going to need to add our auto-approve user to each sub-team that owns repos, e.g., if a telemetry team owns logging repos, does the auto-approve user need to be part of it.
There was a problem hiding this comment.
Yes, we do, but this is only if they want auto-approve and they have subteams. I will add this to the README as well.
| - "package\\.json$" | ||
| - "CHANGELOG\\.md$" | ||
| maxFiles: 3 | ||
| - author: "gcf-owl-bot[bot]" |
There was a problem hiding this comment.
I think we should do the .OwlBot.lock config in a separate PR. I'm personally comfortable with automating merging these files. But @chingor13 had some concerns we should talk through as a group.
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
If we land this as a feat: it's going to trigger release PRs. Let's relabel this as chore:?
bcoe
changed the title
3 participants
No description provided.