Skip to content

fix: release scripts from issuing overlapping phases#1043

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
igorbernstein2:fix-install
Apr 14, 2021
Merged

fix: release scripts from issuing overlapping phases#1043
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
igorbernstein2:fix-install

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

mvn deploy will run mvn install so specifying mvn install deploy is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself

`mvn deploy` will run `mvn install` so specifying `mvn install deploy` is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself
@igorbernstein2 igorbernstein2 requested a review from a team April 14, 2021 17:11
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 8285c2b into googleapis:master Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@igorbernstein2 igorbernstein2 deleted the fix-install branch April 14, 2021 17:22
igorbernstein2 added a commit to igorbernstein2/cloud-bigtable-client that referenced this pull request Apr 14, 2021
gcf-merge-on-green Bot pushed a commit to googleapis/java-bigtable-hbase that referenced this pull request Apr 14, 2021
… on test artifacts (#2922)

- This updates all test artifacts to disable release related plugins: deploy, nexus-staging, site, source, javadoc, gpg, & clirr.
- The integration test modules were failing build because they don't have any prod classes, so maven-jar-plugin would fail because it couldnt find the primary jar. This fixes it by adding placeholder classes
- Finally this pre-emptively applies changes from googleapis/synthtool#1043

fixes #2880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants