Skip to content

Lint fails on Windows on end of line break #464

@summer-ji-eng

Description

@summer-ji-eng

Problem:
googleapis/gcs-resumable-upload ci/windows fail due to linter issue of end of line break style for windows (see here)

To temporary unblock me, I removed posttest in package.json, here

Fix Suggestion from @bcoe:
Instead of add .gitattribute to elf in single repo gcs-resumable-upload for windows (example),

maybe in .github/workflows/ci.yaml , add one extra command for windows that just does:
run: print "*.ts text eol=lf\n*.js test eol=lf" > .gitattributes

Steps to reproduce

  1. add "posttest": "npm run lint", in repo package.json

Feel free to @summer-ji-eng if you have any question. Thanks!

Metadata

Metadata

Assignees

Labels

type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions