Skip to content

[Python] .coveragerc does not respect cov_level variable #1228

@tswast

Description

@tswast

It's templated here:

session.run("coverage", "report", "--show-missing", "--fail-under={{ cov_level if cov_level != None else '100' }}")

But not here:

This causes issues when coverage is run outside of nox -s cover, such as in the conda tests here: googleapis/python-bigquery-pandas#380

https://app.circleci.com/pipelines/github/tswast/python-bigquery-pandas/216/workflows/6a879fea-0c82-4dcc-8b0f-f2542f0e7581/jobs/1307

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions