Skip to content

Commit 5451633

Browse files
Benjamin E. CoeJustinBeckwith
andauthored
build: only check --engine-strict for production deps (#810)
Co-authored-by: Justin Beckwith <[email protected]>
1 parent 7c53709 commit 5451633

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • synthtool/gcp/templates/node_library/.github/workflows

synthtool/gcp/templates/node_library/.github/workflows/ci.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ jobs:
1616
with:
1717
node-version: ${{ '{{' }} matrix.node {{ '}}' }}
1818
- run: node --version
19-
- run: npm install --engine-strict
19+
# The first installation step ensures that all of our production
20+
# dependencies work on the given Node.js version, this helps us find
21+
# dependencies that don't match our engines field:
22+
- run: npm install --production --engine-strict
23+
- run: npm install
2024
- run: npm test
2125
- name: coverage
2226
uses: codecov/codecov-action@v1

0 commit comments

Comments
 (0)