Skip to content

Commit 0e18f75

Browse files
sofislsofisl
authored
build: ignore private repos when walking through repos with release-please (#1860)
* build: ignore private repos when walking through repos with release-please
1 parent fa95f29 commit 0e18f75

18 files changed

Lines changed: 70 additions & 7 deletions

File tree

‎synthtool/languages/node.py‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,15 +277,26 @@ def write_release_please_config(dirs: list):
277277
with open("release-please-config.json", "r") as f:
278278
data = json.load(f)
279279
for dir in dirs:
280+
isPrivate = check_if_private_package(dir)
280281
result = re.search(r"(src/apis/.*)", dir)
281282
assert result is not None
282-
data["packages"][result.group()] = {}
283+
if result and isPrivate is False:
284+
data["packages"][result.group()] = {}
283285
# Make sure base package is also published
284-
data["packages"]["."] = {}
286+
if check_if_private_package(".") is False:
287+
data["packages"]["."] = {}
285288
with open("release-please-config.json", "w") as f:
286289
json.dump(data, f, indent=2)
287290

288291

292+
def check_if_private_package(path: str):
293+
with open(Path(path, "package.json"), "r") as f:
294+
packageJson = json.load(f)
295+
if "private" in packageJson and packageJson["private"] is True:
296+
return True
297+
return False
298+
299+
289300
default_staging_excludes = ["README.md", "package.json", "src/index.ts"]
290301
default_templates_excludes: List[str] = []
291302

‎tests/fixtures/node_apiary/with_private/package.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"name": "gax-nodejs",
3+
"private": true,
4+
"description": "Google API Extensions"
5+
}

‎tests/fixtures/node_apiary/with_private/release-please-config-post-apiary.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"release-type": "node",
3+
"packages": {
4+
"src/apis/docs": {}
5+
}
6+
}

‎tests/fixtures/node_apiary/with_private/release-please-config.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"release-type": "node",
3+
"packages": {
4+
"src/apis/docs": {}
5+
}
6+
}

tests/fixtures/node_apiary/src/apis/admin/index.ts renamed to tests/fixtures/node_apiary/with_private/src/apis/admin/index.ts

File renamed without changes.

‎tests/fixtures/node_apiary/with_private/src/apis/admin/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "admin",
3+
"private": true
4+
}

tests/fixtures/node_apiary/src/apis/docs/index.ts renamed to tests/fixtures/node_apiary/with_private/src/apis/docs/index.ts

File renamed without changes.

‎tests/fixtures/node_apiary/with_private/src/apis/docs/package.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"name": "docs"
3+
}

tests/fixtures/node_apiary/src/apis/index.ts renamed to tests/fixtures/node_apiary/with_private/src/apis/index.ts

File renamed without changes.

‎tests/fixtures/node_apiary/without_private/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "gax-nodejs",
3+
"description": "Google API Extensions"
4+
}

0 commit comments

Comments
 (0)