chore: rework build infrastructure#913
Conversation
meltsufin
left a comment
meltsufin
left a comment
There was a problem hiding this comment.
I like the simplification. I wish we had some way of automatically updating the versions using a bot like we do in other repos.
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 153 153
Lines 16046 16046
Branches 1166 1166
=======================================
Hits 14095 14095
Misses 1607 1607
Partials 344 344 Continue to review full report at Codecov.
|
|
Looks like googleapis/googleapis is referencing I'll have to look into that to resolve the issue. |
|
Turns out it's a trivial fix to remove unused code from googleapis/googleapis. However, there was a chicken-and-egg-like situation, so I ended up upgrading gax-java and gapic-generator-java in googleapis and removing the code after releasing gapic-generator-java. (internal change: 424868012) |
Source-Link: googleapis/synthtool@fbc8bfe Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 participants
Removes
repository_rules.bzlanddependencies.properties. CreatesPROPERTIES.bzlinstead (which was dynamically generated by the rule above previously) to make the whole process straightforward.The
dependencies.properties-pattern is used in other repos (includinggax-java). Its purpose is to avoid dependency versions going out of sync when compiling source between Bazel and Gradle. However, we don't have Gradle, and we won't enable building with two different build systems, so YAGNI.