Skip to content

fix: Use the right composers in deprecation unit tests [ggj]#715

Merged
vam-google merged 1 commit intomasterfrom
dev/deprecation2
Apr 21, 2021
Merged

fix: Use the right composers in deprecation unit tests [ggj]#715
vam-google merged 1 commit intomasterfrom
dev/deprecation2

Conversation

@miraleung
Copy link
Copy Markdown
Contributor

No description provided.

@miraleung miraleung requested a review from a team April 21, 2021 21:20
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2021
@miraleung miraleung requested a review from vam-google April 21, 2021 21:21
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2021

Codecov Report

Merging #715 (0313efd) into master (42dedef) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   92.25%   92.52%   +0.26%     
==========================================
  Files         124      124              
  Lines       13459    13459              
  Branches      981      981              
==========================================
+ Hits        12417    12453      +36     
+ Misses        784      765      -19     
+ Partials      258      241      -17     
Impacted Files Coverage Δ
...pic/composer/ServiceStubSettingsClassComposer.java 99.02% <0.00%> (+0.59%) ⬆️
...r/gapic/composer/ServiceSettingsClassComposer.java 97.85% <0.00%> (+1.25%) ⬆️
...rator/gapic/composer/ServiceStubClassComposer.java 99.19% <0.00%> (+6.45%) ⬆️
...or/gapic/composer/comment/StubCommentComposer.java 96.15% <0.00%> (+7.69%) ⬆️
...apic/composer/comment/SettingsCommentComposer.java 93.93% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dedef...0313efd. Read the comment docs.

@vam-google vam-google merged commit 2318136 into master Apr 21, 2021
@vam-google vam-google deleted the dev/deprecation2 branch April 21, 2021 21:36
suztomo pushed a commit that referenced this pull request Mar 21, 2023
…onfig to v1.5.0 (#715)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0)

##### Features

-   add build scripts for native image testing in Java 17 ([#&#8203;1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#&#8203;475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a))
-   to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09))

##### Dependencies

-   update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants