tests: Add protobuf 3.x compatibility tests with a third party library tensorflow.#4015
tests: Add protobuf 3.x compatibility tests with a third party library tensorflow.#4015blakeli0 merged 7 commits intoprotobuf-4.x-rcfrom
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential compatibility issues by adding dedicated integration tests. It ensures that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new integration test to ensure compatibility with libraries that depend on Protobuf 3.x, using TensorFlow as an example. The changes include adding the TensorFlow dependency to pom.xml and a new test class ITProtobuf3Compatibility.
My review focuses on the new test class. I've found a few issues related to correctness and maintainability. Specifically, the test is missing a key assertion for the calculated result, uses brittle node access, and has incorrect assertions that compare incompatible types. I've provided suggestions to fix these issues to make the test more robust and correct.
...se/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITProtobuf3Compatibility.java
Outdated
Show resolved
Hide resolved
...se/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITProtobuf3Compatibility.java
Outdated
Show resolved
Hide resolved
...se/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITProtobuf3Compatibility.java
Outdated
Show resolved
Hide resolved
...se/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITProtobuf3Compatibility.java
Outdated
Show resolved
Hide resolved
…uf 3 showcase tests as a separate step.
|
|
…y tensorflow. (#4015) Add protobuf 3.x compatibility tests with a third party library tensorflow in showcase module. Tensorflow depends on [protobuf-java v3.21.9](https://github.com/tensorflow/java/blob/cbf942051d55291ba9bdb019b2f207f013889bba/tensorflow-core/pom.xml#L45) gen code and runtime. This proves that client libraries with 4.33 runtime and gen code are compatible with a third party library that contains 3.x gen code and runtime. --------- Co-authored-by: cloud-java-bot <[email protected]>
3 participants
Add protobuf 3.x compatibility tests with a third party library tensorflow in showcase module.
Tensorflow depends on protobuf-java v3.21.9 gen code and runtime. This proves that client libraries with 4.33 runtime and gen code are compatible with a third party library that contains 3.x gen code and runtime.