tests: Add java-showcase-3.21.0#4011
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new java-showcase-3.21.0 module to test compatibility with an older version of protobuf generated code. The changes consist of adding a complete, self-contained module, which appears to be a copy of an existing one with version modifications. The changes are mostly auto-generated code. I've found a minor formatting issue in the README.md file.
| @@ -0,0 +1,2 @@ | |||
| This is a copy of [GAPIC Showcase](https://github.com/googleapis/gapic-showcase) with protobuf 3.21.0 gen code. | |||
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.21.0. No newline at end of file | |||
There was a problem hiding this comment.
This line has trailing whitespace, and the file is missing a final newline. It's good practice to remove trailing whitespace and ensure files end with a newline for consistency and to avoid issues with some tools.
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.21.0. | |
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.21.0. |
|
|
Add a new module java-showcase-3.21.0. This is a copy of the java-showcase module with a different version (3.21.0) of protobuf gen code. This is intended to test the compatibility between protobuf runtime v4.33.0 and gen code 3.21.0. The [gen code contains makeExtensionsImmutable method](https://github.com/googleapis/sdk-platform-java/blob/c80004ad3fdafbf43aa9adf4e8069ac3b4fefaa4/java-showcase-3.21.0/proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java#L90) which proves that it is generated with a protoc version prior to 3.21.7. Add [a new step](https://github.com/googleapis/sdk-platform-java/blob/c80004ad3fdafbf43aa9adf4e8069ac3b4fefaa4/.github/workflows/ci.yaml#L313-L319) in CI to test this module.
2 participants
Add a new module java-showcase-3.21.0. This is a copy of the java-showcase module with a different version (3.21.0) of protobuf gen code. This is intended to test the compatibility between protobuf runtime v4.33.0 and gen code 3.21.0.
The gen code contains makeExtensionsImmutable method which proves that it is generated with a protoc version prior to 3.21.7.
Add a new step in CI to test this module.