chore(librariangen): Generate to use languagecontainer.Run #3968

suztomo · 2025-10-23T15:34:48Z

This pull requests changes the argument parsing/validation logic of the generate command to languagecontainer package. The corresponding test cases have been moved to the languagecontainer package as well.

As a result, the main.go and main_test.go became simpler.

Test to confirm the generate function is called

suztomo@suztomo:~/sdk-platform-java/internal/librariangen$ docker build .
...
 => => writing image sha256:0e0d003ebd405958e90efd9fd835bcc80ef811be00716c7b5fc9ba8e64dc5eb9

suztomo@suztomo:/tmp/librarian$ docker run --rm -v /tmp/librarian:/tmp/librarian sha256:0e0d003ebd405958e90efd9fd835bcc80ef811be00716c7b5fc9ba8e64dc5eb9 generate -librarian /tmp/librarian
time=2025-10-23T18:10:34.048Z level=INFO msg="librariangen: invoked" args="[/usr/local/bin/librariangen generate -librarian /tmp/librarian]"
time=2025-10-23T18:10:34.049Z level=ERROR msg="generate failed" error="librariangen: failed to unzip /output/java_gapic.zip: open /output/java_gapic.zip: no such file or directory"

gemini-code-assist · 2025-10-23T15:35:11Z

Summary of Changes

Hello @suztomo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the librariangen tool's generate command. The changes introduce a new languagecontainer/generate package to centralize configuration and request parsing, moving this logic out of the main generator file. This architectural shift aims to improve modularity, maintainability, and extensibility by aligning the generation process with a more standardized languagecontainer.Run pattern.

Highlights

Refactored Generate Command: The core generate command logic has been refactored to integrate with the new languagecontainer.Run function, promoting a more modular structure.
New Configuration Structures: Introduced new generate.Context and generate.Config structs within a dedicated languagecontainer/generate package to encapsulate directory paths and parsed generation requests.
Centralized Configuration Handling: Configuration parsing and validation, including reading generate-request.json and validating directory paths, are now centralized within the languagecontainer/generate package.
Simplified Generator Logic: The internal/librariangen/generate/generator.go file has been simplified by removing its internal Config struct and Validate method, delegating these responsibilities to the new languagecontainer/generate package.
Main CLI Integration: The main.go entry point now leverages languagecontainer.Run to execute the generate command, passing the generate.Generate function as part of the LanguageContainer struct.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

suztomo · 2025-10-23T15:35:27Z

internal/librariangen/generate/generator.go

 )

-// Config holds the internal librariangen configuration for the generate command.
-type Config struct {


This has moved to languagecontainer.Context.

codecov · 2025-10-23T15:35:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.05%. Comparing base (452d703) to head (ef288e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3968      +/-   ##
==========================================
+ Coverage   78.89%   82.05%   +3.16%     
==========================================
  Files           8        9       +1     
  Lines         379      379              
==========================================
+ Hits          299      311      +12     
+ Misses         53       41      -12     
  Partials       27       27

Flag	Coverage Δ
librariangen	`82.05% <ø> (+3.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

suztomo · 2025-10-23T15:36:10Z

internal/librariangen/generate/generator.go

-// readGenerateReq reads generate-request.json from the librarian-tool input directory.
-// The request file tells librariangen which library and APIs to generate.
-// It is prepared by the Librarian tool and mounted at /librarian.
-func readGenerateReq(librarianDir string) (*message.Library, error) {


This has moved to languagecontainer.generate.NewConfig.

gemini-code-assist

Code Review

This pull request introduces the use of languagecontainer.Run for the generate command, refactors the Generate function to use a generate.Config struct, and adds a new generate package with Context and Config types. The changes also include updates to tests and the main entry point to accommodate the new structure. The review focuses on ensuring the correctness of the new implementation, proper error handling, and adherence to good coding practices.

internal/librariangen/generate/generator.go

internal/librariangen/languagecontainer/languagecontainer.go

internal/librariangen/languagecontainer/languagecontainer_test.go

internal/librariangen/main.go

suztomo · 2025-10-23T17:51:05Z

internal/librariangen/main.go

-}
-
-// handleGenerate parses flags for the generate command and calls the generator.
-func handleGenerate(ctx context.Context, args []string) error {


This moved to languagecontainer package.

meltsufin

This is conflicting a lot with #3967. Can you please make the change in two separate PRs.

changes to main.go
changes to generator.go

suztomo · 2025-10-23T19:09:38Z

@meltsufin I couldn't think of a good way to split it. main.go starts using languagecontainer.Run which pass new languagecontainer.generate.Config to the Generate command (defined in generator.go). The changes are related. How about merging your pull request first and I deal with the conflicts?

…enerate

suztomo · 2025-10-23T21:31:54Z

@meltsufin I merged the main branch. PTAL.

…3968)" This reverts commit 0a1bbea.

chore(librariangen): Generate to use languagecontainer.Run

b68161a

product-auto-label bot added the size: l Pull request size is large. label Oct 23, 2025

suztomo commented Oct 23, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 23, 2025

View reviewed changes

Test to validate the nil functions

d7ce698

suztomo mentioned this pull request Oct 23, 2025

chore(librariangen): languagecontainer package to parse release-init request #3965

Merged

suztomo marked this pull request as draft October 23, 2025 16:55

suztomo added 2 commits October 23, 2025 17:30

Validation moved to languagecontainer

1160ca4

Do not pass the command itself in the argument.

d159ee2

suztomo commented Oct 23, 2025

View reviewed changes

suztomo marked this pull request as ready for review October 23, 2025 18:11

meltsufin requested changes Oct 23, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into languagecontainer_g…

ef288e5

…enerate

suztomo requested a review from meltsufin October 23, 2025 21:32

meltsufin approved these changes Oct 24, 2025

View reviewed changes

suztomo merged commit 0a1bbea into main Oct 24, 2025
50 checks passed

suztomo deleted the languagecontainer_generate branch October 24, 2025 03:58

meltsufin added a commit that referenced this pull request Oct 24, 2025

Revert "chore(librariangen): Generate to use languagecontainer.Run (#…

5101a26

…3968)" This reverts commit 0a1bbea.

chore(librariangen): Generate to use languagecontainer.Run #3968

chore(librariangen): Generate to use languagecontainer.Run #3968

Uh oh!

Conversation

suztomo commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test to confirm the generate function is called

Uh oh!

gemini-code-assist bot commented Oct 23, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

suztomo Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suztomo Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

suztomo Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

meltsufin left a comment

Choose a reason for hiding this comment

Uh oh!

suztomo commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

suztomo commented Oct 23, 2025 •

edited

Loading

codecov bot commented Oct 23, 2025 •

edited

Loading

suztomo commented Oct 23, 2025 •

edited

Loading