Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Oct 21, 2025

Reverts #3953. Due to the change, GitHub Actions stopped running the checks while the checks are still marked as required. Tried this in #3959 (comment).

image

The documentation about this GitHub Actions behavior is https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks :

If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see Using conditions to control job execution.

I didn't find usages of a file path filter in the condition of a job within a workflow.

https://github.com/googleapis/sdk-platform-java/blob/main/.github/workflows/verify_library_generation.yaml#L8 is is a good example how to skip the main job library-generation-unit-tests, by introducing the should-run-library-generation-tests job.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 21, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@suztomo suztomo changed the title Revert "ci: exclude internal/librariangen/** on unrelated checks" chore: revert "ci: exclude internal/librariangen/** on unrelated checks" Oct 21, 2025
@suztomo suztomo requested a review from meltsufin October 21, 2025 00:27
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@meltsufin meltsufin merged commit 49cc63d into main Oct 21, 2025
61 checks passed
@meltsufin meltsufin deleted the revert-3953-skip-ci-librariangen branch October 21, 2025 01:08
meltsufin added a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants