Skip to content

chore(build): fix typo#3828

Merged
zhumin8 merged 4 commits intomainfrom
error_prone
Nov 14, 2025
Merged

chore(build): fix typo#3828
zhumin8 merged 4 commits intomainfrom
error_prone

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 5, 2025

fix a typo.

Did the typo cause any failures for us? Is this dependency necessary?

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 5, 2025
@blakeli0
Copy link
Contributor

blakeli0 commented Jun 10, 2025

Did the typo cause any failures for us? Is this dependency necessary?

It did not probably because it is in dependencyManagement section. I don't think we need this anymore because it is already declared in third-party-dependencies.

Thanks for finding this issue!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Jul 14, 2025

The firestore error is flaky. So is the pubsublite one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 enabled auto-merge (squash) November 14, 2025 15:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 merged commit 58dd467 into main Nov 14, 2025
60 checks passed
@zhumin8 zhumin8 deleted the error_prone branch November 14, 2025 15:58
lqiu96 pushed a commit that referenced this pull request Feb 12, 2026
@zhumin8 @suztomo @lqiu96
chore(build): fix typo (#3828)
fa1c2e7 
fix a typo.

Did the typo cause any failures for us? Is this dependency necessary?

Co-authored-by: Tomo Suzuki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@lqiu96 lqiu96 Awaiting requested review from lqiu96

@JoeWang1127 JoeWang1127 Awaiting requested review from JoeWang1127

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhumin8 @blakeli0 @diegomarquezp @suztomo