test: Reduce the LRO timeout value in Showcase tests #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lqiu96
approved these changes
Mar 10, 2025
zhumin8
approved these changes
Mar 10, 2025
Contributor
zhumin8
left a comment
zhumin8
left a comment
There was a problem hiding this comment.
LGTM.
showcase-clirr failure should be unrelated, might need a separate fix:
/home/runner/work/_temp/7075eb00-7c0c-4b3b-88dc-8f5836aae34a.sh: line 3: cd: showcase: No such file or directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3277
I run the flaky test locally 1000 times but couldn't reproduce the issue. Despite that, reduce the LRO timeout values in the Showcase test
ITLongRunningOperation.testHttpJson_LROUnsuccessfulResponse_exceedsTotalTimeout_throwsDeadlineExceededExceptioncould make the test scenario fail fast and less flaky.