Skip to content

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Mar 8, 2024

In this PR:

  • Write PR description into a file which lives the same directory with the configuration.

Context:
After #2531, we can generate pull request description from generation config and a baseline commit.

However, the return value (string) can not be retrieved when running in docker environment. Therefore, write the description to a file. Put multi-line description to a file also helps editing the pr body (link).

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 8, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

continue
repo = sub_dir.name
if repo == "golden":
if repo == "golden" or repo == "java-bigtable":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable integration test in java-bigtable (issue)

@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 8, 2024 14:26
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 8, 2024 14:26
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) March 8, 2024 14:41
@JoeWang1127 JoeWang1127 merged commit 2659f91 into main Mar 8, 2024
@JoeWang1127 JoeWang1127 deleted the chore/generate_description_to_file branch March 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants