Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Mar 7, 2024

Fixes: #2503

Draft to look into the impact of refactoring the HttpJsonCallableFactory to be like the GrpcCallableFactory.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 7, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@lqiu96 lqiu96 changed the title Update httpjson callables chore: Refactor HttpJson Callables to include Tracing Mar 7, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@blakeli0 blakeli0 closed this Jul 23, 2024
@blakeli0 blakeli0 reopened this Jul 23, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpJson Implementation is recording Operation(Success|Fail) metric before retries are attempted

2 participants