chore: shell code format#1961
Conversation
product-auto-label
Bot
added
size: m
product-auto-label
Bot
added
size: l
JoeWang1127
requested review from
blakeli0,
diegomarquezp,
meltsufin and
suztomo
product-auto-label
Bot
added
size: xl
There was a problem hiding this comment.
This file and the above files are empty because we only care about the file names in tests?
There was a problem hiding this comment.
Yes, we only need the file name.
I assume the generator will verify the contents of the json file.
There was a problem hiding this comment.
I see, thanks! Do you mind adding comments to relevant tests or on top of each file to explain why they are empty? For json, you can not add comments but maybe add a comment field with the content. Either way works, I just want to have something explaining why these files are empty.
There was a problem hiding this comment.
Added a comment in the json file.
There was a problem hiding this comment.
I think we could group these four test yamls to the same folder search_additional_protos as they are testing the same function?
There was a problem hiding this comment.
They can't be in the same folder because there should not have multiple *.yaml (not *gapic.yaml) in a proto_path, but I can group them into sub-folders of search_additional_protos. WDYT?
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
JoeWang1127
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
3 participants
Proposed changes in this PR:
generate_library_integration_test.shtolibrary_generation/test.A follow up of #1948.