Skip to content

chore: Resolve flaky HttpJsonDirectServerStreamingCallableTest test#1915

Merged
lqiu96 merged 5 commits intomainfrom
flaky_test
Aug 17, 2023
Merged

chore: Resolve flaky HttpJsonDirectServerStreamingCallableTest test#1915
lqiu96 merged 5 commits intomainfrom
flaky_test

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Aug 10, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1675 ☕️

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Aug 10, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 16, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 16, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 16, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 marked this pull request as ready for review August 17, 2023 20:27
@lqiu96 lqiu96 requested a review from a team August 17, 2023 20:27
@blakeli0 blakeli0 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@lqiu96 lqiu96 merged commit ca6cd83 into main Aug 17, 2023
@lqiu96 lqiu96 deleted the flaky_test branch August 17, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError

2 participants

@lqiu96 @blakeli0