Conversation
.github/workflows/ci.yaml
Outdated
| run: mvn versions:set -B -ntp -DnewVersion=0.0.2-SNAPSHOT | ||
| - name: Clirr Check | ||
| working-directory: showcase | ||
| run: mvn -B -ntp clirr:check -Dclirr.skip=false -DcomparisonVersion=0.0.1-SNAPSHOT |
There was a problem hiding this comment.
Can we eliminate the assumption about the exact version numbers using something like
mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version?
There was a problem hiding this comment.
Done. Verified in #1804 that new logic continues to catch the binary incompatibility.
| run: | | ||
| SHOWCASE_CLIENT_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) | ||
| mvn versions:set -B -ntp -DnewVersion=local | ||
| mvn clirr:check -B -ntp -Dclirr.skip=false -DcomparisonVersion=$SHOWCASE_CLIENT_VERSION |
There was a problem hiding this comment.
I though that comparisonVersion is the previous "released" version that we should be comparing against, but here it's the PR version. So, I'm a bit confused.
There was a problem hiding this comment.
I guess it works as long as the project version in the PR is the same as the one in the target branch, which should almost always be the case.
There was a problem hiding this comment.
Ah. Yes. You're right. I'll make sure it is always true... sec...
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
2 participants
This check compares the Showcase client against the target branch for binary incompatible changes.
Previous binary incompatibilities have been caught with the java-iam client, but:
See #1804 for an example of this check catching a binary incompatible change.