Skip to content

chore: do not merge. showcase-clirr test PR#1804

Closed
burkedavison wants to merge 7 commits intomainfrom
showcase-clirr-verify
Closed

chore: do not merge. showcase-clirr test PR#1804
burkedavison wants to merge 7 commits intomainfrom
showcase-clirr-verify

Conversation

@burkedavison
Copy link
Member

@burkedavison burkedavison commented Jun 23, 2023

No description provided.

@burkedavison burkedavison added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 23, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 23, 2023
@burkedavison
Copy link
Member Author

burkedavison commented Jun 23, 2023

First commit tests failed because the showcase source was not updated to reflect the dependency change.

Good. This proves we don't need to perform generation during showcase-clirr.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Jun 23, 2023
@burkedavison
Copy link
Member Author

burkedavison commented Jun 23, 2023

With showcase goldens updated, showcase-clirr now failing with binary incompatibilities.

Good.

@burkedavison burkedavison mentioned this pull request Jun 23, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Base automatically changed from showcase-clirr to main June 23, 2023 19:19
@burkedavison
Copy link
Member Author

burkedavison commented Jun 23, 2023

Testing complete.

@burkedavison burkedavison deleted the showcase-clirr-verify branch June 23, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@burkedavison