Skip to content

chore: exclude .iml files in showcase's verify.sh diff check#1689

Merged
diegomarquezp merged 1 commit intomainfrom
showcase-iml-exclusion
May 18, 2023
Merged

chore: exclude .iml files in showcase's verify.sh diff check#1689
diegomarquezp merged 1 commit intomainfrom
showcase-iml-exclusion

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented May 18, 2023

This prevents failure on mvn verify when there are (gitignored) .iml files in showcase/gapic-showcase/**/*

@diegomarquezp diegomarquezp requested a review from a team May 18, 2023 19:33
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 18, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp merged commit 745ea58 into main May 18, 2023
@diegomarquezp diegomarquezp deleted the showcase-iml-exclusion branch May 18, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants