test: refactor test-related helpers for gapic-generator-java for inclusion in testlib jar#1648
Merged
test: refactor test-related helpers for gapic-generator-java for inclusion in testlib jar#1648
Conversation
emmileaf
changed the title
This was referenced May 2, 2023
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
emmileaf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
meltsufin
approved these changes
May 10, 2023
blakeli0
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: In GoogleCloudPlatform/spring-cloud-gcp#1686, spring-cloud-gcp's code generator shares similar testing setup with gapic-generator-java and can benefit from test-scoped helper classes being also published as jar.
This PR takes the approach of creating an attached jar over a separate module (e.g. gapic-test), out of the two options described https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html.
For reviewers: Most code changes in the PR are from refactoring: to consolidate helper classes for gapic-generator-java tests under
com.google.api.generator.test, and away from test classes themselves. Aside from package name changes in tests, the main file changes from refactoring and publishing the test jar are inpom.xmlandgapic-generator-java/src/test/java/com/google/api/generator/test.