Skip to content

chore: Add pagination showcase tests#1635

Merged
lqiu96 merged 12 commits intomainfrom
main-showcase_pagination
Jun 21, 2023
Merged

chore: Add pagination showcase tests#1635
lqiu96 merged 12 commits intomainfrom
main-showcase_pagination

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Apr 18, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Part of #1439 ☕️

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 18, 2023
@lqiu96 lqiu96 mentioned this pull request Apr 18, 2023
Closed
27 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 18, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 18, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 18, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 changed the title chore: Add pagination showcase tests for httpjson chore: Add pagination showcase tests Jun 9, 2023
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@lqiu96 lqiu96 marked this pull request as ready for review June 9, 2023 19:09
@lqiu96 lqiu96 requested a review from a team June 9, 2023 19:09
mpeddada1
mpeddada1 reviewed Jun 12, 2023
View reviewed changes
mpeddada1
mpeddada1 approved these changes Jun 13, 2023
View reviewed changes
@lqiu96
Copy link
Member Author

lqiu96 commented Jun 20, 2023

@burkedavison @blakeli0 Could you also review whenever you get a chance?

blakeli0
blakeli0 reviewed Jun 21, 2023
View reviewed changes
showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITPagination.java Outdated
// the content is correct.
//
// The pageToken is where the streaming responses come back from and the page size denotes
// how many of the responses come back together. i.e for PageSize = 2 and PageToken = 1, see
Copy link
Contributor

@blakeli0 blakeli0 Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind making the PageToken a larger value like 3 to make it clearer? Maybe it's just me but it took me a while to figure out that what X means, I thought X and 0 are a pair ;)

Copy link
Member Author

@lqiu96 lqiu96 Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do! I'll change it to - and hopefully that'll be clearer for others too.

blakeli0
blakeli0 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a minor comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 21, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 21, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 21, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit 56033d5 into main Jun 21, 2023
@lqiu96 lqiu96 deleted the main-showcase_pagination branch June 21, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@burkedavison burkedavison Awaiting requested review from burkedavison

+1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lqiu96 @blakeli0 @mpeddada1