Skip to content

chore: Update showcase to latest version#1597

Merged
lqiu96 merged 2 commits intomainfrom
main-update_showcase_version
Apr 3, 2023
Merged

chore: Update showcase to latest version#1597
lqiu96 merged 2 commits intomainfrom
main-update_showcase_version

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Mar 31, 2023 •
edited
Loading

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Update the latest version to include this fix: googleapis/gapic-showcase#1282

@lqiu96 lqiu96 requested review from a team, burkedavison and mpeddada1 March 31, 2023 21:06
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 31, 2023
mpeddada1
mpeddada1 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be automated through renovate-bot? (https://docs.renovatebot.com/modules/datasource/github-releases/) cc/ @burkedavison

@lqiu96
Copy link
Member Author

lqiu96 commented Mar 31, 2023 •
edited
Loading

Could this be automated through renovate-bot? (https://docs.renovatebot.com/modules/datasource/github-releases/) cc/ @burkedavison

Oh, that's cool! Let me try that before merging this in (adding in a temp Do not merge). I was thinking about making a GH action in the future, but this might be easier.

@lqiu96 lqiu96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lqiu96
Copy link
Member Author

lqiu96 commented Apr 3, 2023

Could this be automated through renovate-bot? (https://docs.renovatebot.com/modules/datasource/github-releases/) cc/ @burkedavison

Oh, that's cool! Let me try that before merging this in (adding in a temp Do not merge). I was thinking about making a GH action in the future, but this might be easier.

This is taking a bit longer than I thought to set it up and test. I'll create an issue to track this, but I'll merge this in for now.

@lqiu96 lqiu96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2023
@lqiu96 lqiu96 merged commit fd66701 into main Apr 3, 2023
@lqiu96 lqiu96 deleted the main-update_showcase_version branch April 3, 2023 15:45
@lqiu96 lqiu96 mentioned this pull request Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison Awaiting requested review from burkedavison

1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96 @mpeddada1