Skip to content

chore: Add HttpJson CRUD Showcase tests#1589

Merged
lqiu96 merged 16 commits intomainfrom
main-showcase_crud
Apr 12, 2023
Merged

chore: Add HttpJson CRUD Showcase tests#1589
lqiu96 merged 16 commits intomainfrom
main-showcase_crud

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Mar 30, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Part of #1439 ☕️

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 30, 2023
@lqiu96 lqiu96 changed the title Main showcase crud chore: Add HttpJson CRUD Showcase tests Mar 30, 2023
@lqiu96 lqiu96 mentioned this pull request Mar 30, 2023
Closed
27 tasks
@lqiu96
Copy link
Member Author

lqiu96 commented Mar 30, 2023 •
edited
Loading

Failure is resolved with this fix: googleapis/gapic-showcase#1263 -- Released in Showcase v0.26.1.

Will create a separate PR to upgrade to the latest showcase version to unblock this PR.

@lqiu96 lqiu96 marked this pull request as ready for review April 5, 2023 17:11
@lqiu96 lqiu96 requested a review from a team April 5, 2023 17:11
@lqiu96
Copy link
Member Author

lqiu96 commented Apr 10, 2023

@burkedavison @mpeddada1 @blakeli0 Would you all be able to re-review this PR?

mpeddada1
mpeddada1 reviewed Apr 10, 2023
View reviewed changes
@lqiu96
Copy link
Member Author

lqiu96 commented Apr 11, 2023

Thanks all. Will merge tomorrow if unless there are any more concerns.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 11, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit 59efbbb into main Apr 12, 2023
@lqiu96 lqiu96 deleted the main-showcase_crud branch April 12, 2023 14:00
blakeli0
blakeli0 reviewed Apr 12, 2023
View reviewed changes
showcase/gapic-showcase/pom.xml
<version>2.9</version>
<configuration>
<filesNamePattern>(IT.*\.java)|(.*Test.java)</filesNamePattern>
<filesNamePattern>(IT.*\.java)|(.*Test.java)|(TestClientInitializer.java)</filesNamePattern>
Copy link
Contributor

@blakeli0 blakeli0 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we are explicitly specifying the files in the fmt plugin, because we want to exclude some files? @mpeddada1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 left review comments

@burkedavison burkedavison burkedavison approved these changes

+1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lqiu96 @blakeli0 @burkedavison @mpeddada1