[do not merge] prepare for migration of spring generator code#1580
[do not merge] prepare for migration of spring generator code#1580
Conversation
…ode needs cleanup.
…oud-[name]-[v]-java/spring/src/main/...
…trySettingsComposer to help generate declare,getter,setters for retrysettings in properties. Other WIP changes in AutoConfig.
…adding todo notes as reminder to revisit.
…ending to do after annotation feature in.
… Also extracted method to gen spring property prefix string to util method, so all 3 occurances in sync.
…golden tests (#1348) This PR is a follow-up on #1343: - Extends fix to SpringPropertiesClassComposer, so that for services without REST-enabled rpcs, the unused useRest property is also not generated - Adds golden tests for the updated hasRestOption scenario using the wicked proto - Updates SpringAutoconfigCommentComposer for javadoc comments alluding to the useRest option
… with commons-logging dep
emmileaf
added
the
spring
emmileaf
added
the
do not merge
…leParamsAndReturn in main
|
|
||
| @Before | ||
| public void setUp() { | ||
| this.context = TestProtoLoader.instance().parseShowcaseEcho(); |
There was a problem hiding this comment.
We may need to migrate these test protos as well, as they would not exist in the resources anymore.
There was a problem hiding this comment.
Yes - thank you for noting! The two test protos that need to be copied are echo.proto and wicked.proto.
There was a problem hiding this comment.
Hmm this might apply to the usages of TestProtoLoader and GrpcRestTestProtoLoader as well - @blakeli0 do we publish (or intend to publish) a test jar for gapic-generator-java to maven central? If not, we can also migrate an adapted version of these loaders as spring generator test utils, along with the copied protos.
|
[gapic-generator-java-root] SonarCloud Quality Gate failed. |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
| <module>gapic-generator-java</module> | ||
| <module>java-common-protos</module> | ||
| <module>java-iam</module> | ||
| <module>gapic-generator-java</module> |
There was a problem hiding this comment.
Without this change, presubmit builds (e.g. build(11)) fail on building from root.
Error: Failed to execute goal on project gapic-generator-java: Could not resolve dependencies for project com.google.api:gapic-generator-java:jar:2.16.1-SNAPSHOT:
Could not find artifact com.google.api.grpc:proto-google-iam-v1:jar:1.10.1-SNAPSHOT in google-maven-central-copy (https://maven-central.storage-download.googleapis.com/maven2) -> [Help 1]
Switching the submodules order resolved the issue for this PR, though I haven’t pinpointed which part of the changes led to existing build order breaking.
Leaving a note here for posterity, but will stop investigating for now since these code changes intend to be migrated away to a different repo.
|
Closing - spring generator code has been migrated as part of GoogleCloudPlatform/spring-cloud-gcp#1686. |
8 participants
Not intended for merge.
This PR is to compare changes introduced in
autoconfig-gen-draft2branch (spring generator) against the currentmainbranch after resolving conflicts, in preparation for migration to a separate bazel module in spring-cloud-gcp alongside the generated starters.Verified spring generation workflow against this branch (as of 0b7af16) locally and in test action run.
For reviewers: mostly looking for a review on anything expected or missed in to-be-migrated changes, and on latest commits (cdc92b1 and later) manually resolving conflicts, if you have time to take a quick look :)