feat(comment): autoconfig gen draft2 javadoc2#1060
Merged
diegomarquezp merged 7 commits intoautoconfig-gen-draft2from Nov 3, 2022
Merged
feat(comment): autoconfig gen draft2 javadoc2#1060diegomarquezp merged 7 commits intoautoconfig-gen-draft2from
diegomarquezp merged 7 commits intoautoconfig-gen-draft2from
Conversation
diegomarquezp
force-pushed
the
autoconfig-gen-draft2-javadoc2
branch
from
f0ed046 to
b966d6b
Compare
diegomarquezp
changed the title
diegomarquezp
changed the title
zhumin8
added
the
spring
emmileaf
reviewed
Oct 13, 2022
...n/java/com/google/api/generator/spring/composer/comment/SpringAutoconfigCommentComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/spring/composer/comment/CommentComposer.java
Outdated
Show resolved
Hide resolved
zhumin8
requested changes
Oct 17, 2022
Contributor
zhumin8
left a comment
zhumin8
left a comment
There was a problem hiding this comment.
Added my two-cents on some of the wording. (For some of them, I took the easy route and commented on the golden files instead.) It might also worth to go over the wording of these with the whole team in our meetings?
...n/java/com/google/api/generator/spring/composer/comment/SpringAutoconfigCommentComposer.java
Outdated
Show resolved
Hide resolved
...n/java/com/google/api/generator/spring/composer/comment/SpringAutoconfigCommentComposer.java
Outdated
Show resolved
Hide resolved
...n/java/com/google/api/generator/spring/composer/comment/SpringPropertiesCommentComposer.java
Outdated
Show resolved
Hide resolved
...est/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfiguration.golden
Outdated
Show resolved
Hide resolved
...est/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfiguration.golden
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/spring/composer/comment/CommentComposer.java
Outdated
Show resolved
Hide resolved
diegomarquezp
force-pushed
the
autoconfig-gen-draft2-javadoc2
branch
2 times, most recently
from
ab15c44 to
39a243d
Compare
…p for all Spring classes generated (#1062) this pr: - adds a @BetaApi annotation for each class composed in SpringComposer - also moves the @generated("by gapic-generator-java") annotation to SpringComposer for consistency. (this annotation was missing for the properties class composer.) - Updating annotations in SpringComposer level for the ones that applies to all classes makes it easier for future changes when needed.
diegomarquezp
force-pushed
the
autoconfig-gen-draft2-javadoc2
branch
from
adb457b to
ea84a81
Compare
Contributor
Author
|
Force pushed a rebase |
|
Kudos, SonarCloud Quality Gate passed! |
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
….6.23 (#1060) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.22` -> `1.6.23` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.23`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​1623-httpsgithubcomgoogleapisjava-iamcomparev1622v1623-2022-12-20) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.22...v1.6.23) ##### Dependencies - Update dependency com.google.api:api-common to v2.3.1 ([#​567](https://togithub.com/googleapis/java-iam/issues/567)) ([17e62e8](https://togithub.com/googleapis/java-iam/commit/17e62e80f0ea8c2d4edfe6bb16ef5ee7acbc22f3)) - Update dependency com.google.auth:google-auth-library-oauth2-http to v1.14.0 ([#​571](https://togithub.com/googleapis/java-iam/issues/571)) ([9c48311](https://togithub.com/googleapis/java-iam/commit/9c48311fbac25f9c9545f3404a42cdadf8ebb243)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#​565](https://togithub.com/googleapis/java-iam/issues/565)) ([32be2fb](https://togithub.com/googleapis/java-iam/commit/32be2fb0cfafa3681489c18e367cf12f22c567d3)) - Update dependency com.google.cloud:google-iam-policy to v1.6.22 ([#​560](https://togithub.com/googleapis/java-iam/issues/560)) ([de39d89](https://togithub.com/googleapis/java-iam/commit/de39d89c08c9e45bc977ea393570a8d01cf48af2)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.12 ([#​563](https://togithub.com/googleapis/java-iam/issues/563)) ([607e260](https://togithub.com/googleapis/java-iam/commit/607e2601b71ff1fb51406e6c97dd79208296f404)) - Update dependency com.google.protobuf:protobuf-java to v3.21.12 ([#​564](https://togithub.com/googleapis/java-iam/issues/564)) ([4b2b26b](https://togithub.com/googleapis/java-iam/commit/4b2b26bd29d88ccb602a71225d6e2decb49b9649)) - Update dependency io.grpc:grpc-protobuf to v1.51.1 ([#​573](https://togithub.com/googleapis/java-iam/issues/573)) ([2143ec8](https://togithub.com/googleapis/java-iam/commit/2143ec8a90dbcdb128dffea9777fa9d183c3068e)) - Update dependency io.grpc:grpc-stub to v1.51.1 ([#​574](https://togithub.com/googleapis/java-iam/issues/574)) ([488496a](https://togithub.com/googleapis/java-iam/commit/488496aa09c9d976bf0c450fb8584f07e7c74c03)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added javadoc comments to
[Service]AutoConfigand[Service]Properties