Skip to content

fix(Spring CodeGen): Use service-specific CredentialsProvider in annotation#1055

Merged
emmileaf merged 2 commits intoautoconfig-gen-draft2from
autoconfig-qualifier-fix
Oct 7, 2022
Merged

fix(Spring CodeGen): Use service-specific CredentialsProvider in annotation#1055
emmileaf merged 2 commits intoautoconfig-gen-draft2from
autoconfig-qualifier-fix

Conversation

@emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Oct 5, 2022 •
edited
Loading

This PR addresses a follow-up on Qualifier annotations added: #1045 (comment)

  • Renames credential provider from googleCredentials to [serviceName]Credentials in both qualifier annotation and generated method definition.

@emmileaf emmileaf requested a review from zhumin8 October 5, 2022 13:47
@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Oct 5, 2022
@emmileaf emmileaf marked this pull request as ready for review October 5, 2022 13:59
@emmileaf emmileaf requested review from a team October 5, 2022 13:59
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 5, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

zhumin8
zhumin8 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java Outdated
CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, service.name()) + "Client";

String credentialsProviderName =
CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, service.name()) + "Credentials";
Copy link
Contributor

@zhumin8 zhumin8 Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might worth to extract these two names and pass in as parameters? This way, future changes to the names won't cause a mismatch between bean name and qualifier.

Copy link
Contributor Author

@emmileaf emmileaf Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Just pushed a new commit to switch some method names into parameters - is this aligned with what you were thinking of?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@emmileaf emmileaf requested a review from zhumin8 October 6, 2022 19:38
@emmileaf emmileaf merged commit 8de6c5c into autoconfig-gen-draft2 Oct 7, 2022
@emmileaf emmileaf deleted the autoconfig-qualifier-fix branch October 7, 2022 14:34
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@dependabot @gcf-owl-bot
build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /.kokoro (#1055
6d45133 
)

* build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /.kokoro

Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](certifi/python-certifi@2022.09.24...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhumin8 zhumin8 zhumin8 approved these changes

Assignees

No one assigned

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmileaf @zhumin8