-
Notifications
You must be signed in to change notification settings - Fork 69
Open
Labels
priority: p4type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Discovered in the Otel Draft PR: #2500
The Method Name is different between the two transports:
gRPC: Echo.Echo
HttpJson: google.showcase.v1beta1.Echo/Echo.
I believe this is because of the different Regex Matchers used to extract the MethodName:
gRPC:
sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallableFactory.java
Line 69 in 7902a41
| private static final Pattern FULL_METHOD_NAME_REGEX = Pattern.compile("^.*?([^./]+)/([^./]+)$"); |
HttpJson:
Line 58 in 7902a41
| private static final Pattern FULL_METHOD_NAME_REGEX = Pattern.compile("^(.+)\\.(.+)$"); |
We should be consistent and pick one way to display the method name.
Metadata
Metadata
Assignees
Labels
priority: p4type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.