fix: privately-scoped vars in ServiceClientTest codegen (#377)

miraleung · web-flow · commit c004e9cdb40c · 2020-10-09T18:14:59.000-07:00
diff --git a/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java
@@ -186,7 +186,7 @@ private static List<Statement> createClassMemberFieldDecls(
                 ExprStatement.withExpr(
                     v.toBuilder()
                         .setIsDecl(true)
-                        .setScope(ScopeNode.PUBLIC)
+                        .setScope(ScopeNode.PRIVATE)
                         .setIsStatic(v.type().reference().name().startsWith("Mock"))
                         .build()))
         .collect(Collectors.toList());
diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden
@@ -37,10 +37,10 @@ import org.junit.Test;
 
 @Generated("by gapic-generator-java")
 public class EchoClientTest {
-  public static MockServiceHelper mockServiceHelper;
-  public static MockEcho mockEcho;
-  public EchoClient client;
-  public LocalChannelProvider channelProvider;
+  private static MockServiceHelper mockServiceHelper;
+  private static MockEcho mockEcho;
+  private EchoClient client;
+  private LocalChannelProvider channelProvider;
 
   @BeforeClass
   public static void startStaticServer() {
