Skip to content

Commit a156256

Browse files
committed
fix: comment, request params
1 parent 98e24ce commit a156256

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

test/integration/apis/kms/v1/cloudkms_test_mixins_v1.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ documentation:
3333
# Test the overriding of comments.
3434
- selector: google.iam.v1.IAMPolicy.TestIamPermissions
3535
description: |-
36-
This is a different comment for TestIamPermissions in the yaml file
37-
that should clobber the documentation in iam_policy.proto.
36+
This is a different comment for TestIamPermissions in the yaml file that should clobber the documentation in iam_policy.proto.
3837
3938
http:
4039
rules:

test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3333,7 +3333,7 @@ public final UnaryCallable<GetLocationRequest, Location> getLocationCallable() {
33333333

33343334
// AUTO-GENERATED DOCUMENTATION AND METHOD.
33353335
/**
3336-
* This is a different comment for TestIamPermissions in the yaml filethat should clobber the
3336+
* This is a different comment for TestIamPermissions in the yaml file that should clobber the
33373337
* documentation in iam_policy.proto.
33383338
*
33393339
* <p>Sample code:
@@ -3359,7 +3359,7 @@ public final TestIamPermissionsResponse testIamPermissions(TestIamPermissionsReq
33593359

33603360
// AUTO-GENERATED DOCUMENTATION AND METHOD.
33613361
/**
3362-
* This is a different comment for TestIamPermissions in the yaml filethat should clobber the
3362+
* This is a different comment for TestIamPermissions in the yaml file that should clobber the
33633363
* documentation in iam_policy.proto.
33643364
*
33653365
* <p>Sample code:

test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,12 @@ public class KeyManagementServiceClientTest {
7676
@BeforeClass
7777
public static void startStaticServer() {
7878
mockKeyManagementService = new MockKeyManagementService();
79-
mockLocations = new MockLocations();
8079
mockIAMPolicy = new MockIAMPolicy();
80+
mockLocations = new MockLocations();
8181
mockServiceHelper =
8282
new MockServiceHelper(
8383
UUID.randomUUID().toString(),
84-
Arrays.<MockGrpcService>asList(mockKeyManagementService, mockLocations, mockIAMPolicy));
84+
Arrays.<MockGrpcService>asList(mockKeyManagementService, mockIAMPolicy, mockLocations));
8585
mockServiceHelper.start();
8686
}
8787

test/integration/goldens/kms/com/google/cloud/kms/v1/stub/GrpcKeyManagementServiceStub.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -783,8 +783,8 @@ public Map<String, String> extract(GetIamPolicyRequest request) {
783783
@Override
784784
public Map<String, String> extract(ListLocationsRequest request) {
785785
ImmutableMap.Builder<String, String> params = ImmutableMap.builder();
786-
params.put("display_name", String.valueOf(request.getDisplayName()));
787-
params.put("location_id", String.valueOf(request.getLocationId()));
786+
params.put("filter", String.valueOf(request.getFilter()));
787+
params.put("page_size", String.valueOf(request.getPageSize()));
788788
return params.build();
789789
}
790790
})

0 commit comments

Comments
 (0)