Skip to content

Commit a0f88b9

Browse files
authored
chore: add TODO to allow-listed generation of unused resnames (#822)
1 parent b8310ee commit a0f88b9

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • src/main/java/com/google/api/generator/gapic/protoparser

src/main/java/com/google/api/generator/gapic/protoparser/Parser.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,8 @@ public static GapicContext parse(CodeGeneratorRequest request) {
164164

165165
Preconditions.checkState(!services.isEmpty(), "No services found to generate");
166166

167+
// TODO(vam-google): Figure out whether we should keep this allowlist or bring
168+
// back the unused resource names for all APIs.
167169
// Temporary workaround for Ads, who still need these resource names.
168170
if (services.get(0).protoPakkage().startsWith("google.ads.googleads.v")) {
169171
Function<ResourceName, String> typeNameFn =

0 commit comments

Comments
 (0)